Build/pnpm #21
Merged
Build/pnpm #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matijs
force-pushed
the
build/pnpm
branch
2 times, most recently
from
61c4738 to
6811ed6
Compare
matijs
commented
Jan 25, 2024
matijs
commented
Jan 25, 2024
Robbert
requested changes
Jan 25, 2024
- Add `save-exact=true` and `save-prefix=` to .npmrc
- Add `public-hoist-pattern[]` to .npmrc
- Convert to pnpm from npm
- Remove package-lock.json
- Add pnpm-lock.yaml
- Update workflows/continuous-integration.yml
- Replace the use of npm with pnpm
- Update actions to their latest versions where possible
- Precede the `actions/setup-node` step by the `pnpm/setup-action`
step so the `actions/setup-node` can automatically set up the cache
for this step
Something about hoisting
- Remove and re-add all dependencies that were not saved with their exact version - wp-prettier is a drop-in replacement for prettier and should be called as prettier instead of wp-prettier - Fix all linting issues - Update .npmpackagejsonlintrc.json to allow `@nl-design-system-community`
Robbert
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
save-exact=trueandsave-prefix=actions/setup-nodestep by thepnpm/setup-actionstep so theactions/setup-nodecan automatically set up the cache for this step