Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Next.js examples #228

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Super-Kenil
Copy link
Contributor

The examples includes latest Nextjs v14, TS and JS versions for,
This example can replace the old Nextjs example as well

I can open another PR after removing the older Nextjs Example after you merge this PR

Copy link

vercel bot commented Jun 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jarallax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 7:07am

@nk-o
Copy link
Owner

nk-o commented Jul 16, 2024

Hi,

Thank you for your pull request. However, I don't think it can replace the original example. It differs significantly and alters key parts of the old example, such as removing the component with the img tag and changing the initialization code, etc... Additionally, it adds several unnecessary files like readme and lock files, etc..., which are not needed for a simple example.

@Super-Kenil
Copy link
Contributor Author

That's why I allowed edits by maintainers, in case you feel to change something.

Let me know things you would like to change, will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants