-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Originally, the minimum required GCC version was version 6, which didn't have support for the C++17 Filesystem library. However, with our minimum requirement being GCC version 9, we now can use std::filesystem and drop a few of our hand-rolled implementations. Ideally, I'd even go so far as to even cut down blackhole.cc, which uses access() to check whether the temporary directory is writable and uses the best possible but writable one. Obviously, this isn't portable, but given that ip2unix for example will probably never work natively on Windows, I think it's fine to leave it as is, since using std::filesystem APIs won't actually assure that the underlying syscall would be access() anymore. Nevertheless however, this should pave the way to port ip2unix to Darwin and possibly BSD one day. Signed-off-by: aszlig <[email protected]>
- Loading branch information
Showing
2 changed files
with
11 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters