Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump GitHub action runner #2417

Merged
merged 3 commits into from
Jun 2, 2024
Merged

Conversation

SteveLauC
Copy link
Member

@SteveLauC SteveLauC commented May 25, 2024

What does this PR do

Bump GitHub action runner:

  • macos-14 -> macos-latest

    Currently, macos-latest is macos-14, so no changes for now.

  • ubuntu-20.04 -> ubuntu-latest

Update:

For cross test, we would still use Ubuntu 20.04 due to this issue: #2418.

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@SteveLauC
Copy link
Member Author

Created an issue #2418 for that CI failure, do you think we should ignore this test under QEMU? cc @asomers

@SteveLauC
Copy link
Member Author

Created an issue #2418 for that CI failure, do you think we should ignore this test under QEMU? cc @asomers

I think we should still use Ubuntu 20.04 for that cross test as it won't harm anything until 20.04 is no longer available.

When 20.04 becomes deprecated, if this issue still exists, we will ignore it, or we can happily migrate to newer versions.

@SteveLauC SteveLauC added this pull request to the merge queue Jun 2, 2024
Merged via the queue into nix-rust:master with commit 1939f92 Jun 2, 2024
36 checks passed
@SteveLauC SteveLauC deleted the ci/runner branch June 2, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant