-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys: add MIPS R6 support #2138
sys: add MIPS R6 support #2138
Conversation
39b6ad9
to
7f2528b
Compare
Thanks for doing this! I think I will give it a check after dealing with our CI migration |
I'll migrate my log to towncrier soon |
Upstream PRs:
Targets docs: mipsisa*r6*-unknown-linux-gnu* Changes LGTM, but in case something could go wrong, I would like to have @asomers give this a double check |
all( | ||
qemu, | ||
any( | ||
target_arch = "mips", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a good candidate for cfg_aliases, which we have discussed for other purposes.
https://docs.rs/cfg_aliases/latest/cfg_aliases/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are gonna replace most big-chunk, common cfg!
s with some aliases, then it might be better to do it in another, dedicated PR, where we can replace them all and get them well documented in CONTRIBUTING.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2188 issue filed, Let's merge this PR as-is
@chenx97 you'll need to rebase your PR to fix CI. |
Currently R6 targets are almost identical to their R2/R5 counterparts.
There seems to be something wrong with our merge queue, the GHA checks simply don't run, then it reaches the timeout and gets removed from the queue Update: seems that this is what we missed https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue#triggering-merge-group-checks-with-github-actions |
Currently R6 targets are almost identical to their R2/R5 counterparts.
Currently, R6 targets are almost identical to their R2/R5 counterparts. So we add target_arch and bump libc.