plugins/dap: migrate to mkNeovimPlugin #2897
Conversation
khaneliman
force-pushed
the
dap
branch
5 times, most recently
from
00fac7c to
690a920
Compare
khaneliman
force-pushed
the
dap
branch
5 times, most recently
from
765b08c to
9b80a74
Compare
khaneliman
force-pushed
the
dap
branch
4 times, most recently
from
7b5dc4a to
30c289b
Compare
There was a problem hiding this comment.
I'm not too confident with this part of the codebase, but I don't see any issues.
I'd feel better if @GaetanLepage or @traxys could also review before merging, assuming they have time.
|
Was testing with this branch for a bit and then wanted to test lazy loading. Had a couple tweaks for the packPathNames and the final generated config for dap 
|
|
Alright, lazy loading is working with this PR. 
vs
|
|
|
||
| clear_on_continue = defaultNullOpts.mkBool false "Clear virtual text on `continue` (might cause flickering when stepping)."; | ||
|
|
||
| display_callback = defaultNullOpts.mkLuaFn '' |
There was a problem hiding this comment.
I would rather drop mkLuaFn in favor of mkRaw.
There was a problem hiding this comment.
Bearing in mind this is a migration, wouldn't that be a breaking change?
There was a problem hiding this comment.
I intentionally left these alone.
There was a problem hiding this comment.
Makes sense. Ok for me then !
|
|
||
| customConfigurations = mkNullOrOption (types.listOf dapHelpers.configurationOption) "Custom python configurations for dap."; | ||
|
|
||
| resolvePython = defaultNullOpts.mkLuaFn null '' |
There was a problem hiding this comment.
Same here, I would rather go for mkRaw.
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 32aa73a |
|
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
No description provided.