Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix badge URL in README #20

Closed
wants to merge 1 commit into from
Closed

Fix badge URL in README #20

wants to merge 1 commit into from

Conversation

purcell
Copy link
Member

@purcell purcell commented Apr 24, 2024

No description provided.

Signed-off-by: Steve Purcell <[email protected]>
@purcell
Copy link
Member Author

purcell commented Apr 24, 2024

Struggling to see why it's helpful to have the pedantic commit / PR message checking in this very low-traffic repo. This PR was a simple doc fix via the GitHub editor.

  • It's not necessary to discourage casual contributors by making them re-work their PRs to fit title style guides
  • Since adding this checker, the only effect has been NO-ISSUE cruft in all commits

@remi-gelinas
Copy link
Collaborator

Mostly it was to ensure commits adhered to conventional spec, so automatic versioning and releases could be done. That being said, at this point I agree - it would be far simpler to manually tag for release I think, and workflow off of that. Once I've been added as the team owner for this repo again I will rework the release flow to make contribution easier.

@purcell
Copy link
Member Author

purcell commented Apr 29, 2024

Makes sense. Perhaps @adisbladis (as local Emacs + Nix head honcho) would be able to make you a team owner?

@remi-gelinas
Copy link
Collaborator

Yep, I've just pinged him in the original repo transfer thread again to get some eyes on it!

@remi-gelinas
Copy link
Collaborator

@purcell Realized I totally blanked and included this in #23 - sorry about that. I'll close this out as it's done!

@purcell
Copy link
Member Author

purcell commented May 7, 2024

Haha, no worries — thanks!

@remi-gelinas remi-gelinas deleted the purcell-patch-1 branch May 7, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants