Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: support Emacs 29.2 #18

Closed
wants to merge 2 commits into from
Closed

ci: support Emacs 29.2 #18

wants to merge 2 commits into from

Conversation

panchoh
Copy link

@panchoh panchoh commented Feb 17, 2024

Emacs 29.2¹ recently hit both nixos-unstable² and release-23.11³

¹ https://lists.gnu.org/archive/html/emacs-devel/2024-01/msg00666.html

² NixOS/nixpkgs#281789
https://nixpk.gs/pr-tracker.html?pr=281789

³ NixOS/nixpkgs#282259
https://nixpk.gs/pr-tracker.html?pr=282259

I hope I've understood correctly the purpose of both the var in the flake and the one in the workflow.

@panchoh panchoh changed the title Update supported emacs versions ci: NO-ISSUE update supported emacs versions Feb 17, 2024
@panchoh
Copy link
Author

panchoh commented Feb 17, 2024

(I've noticed that the test CI / lint-nix / nixpkgs-fmt fails, but that's to be expected, since flake.nix is not currently formatted following nixpkgs-fmt style).

@remi-gelinas
Copy link
Collaborator

remi-gelinas commented May 7, 2024

Hey @panchoh! Sorry for the long wait on getting to this, we've transferred the repo over to nix-community to get some more maintaining help. We've rewritten some of the actions for releasing, and removed the redundant env var you pointed out, so you should be able to rebase on the latest trunk and just add 29.2 to the flake var to add support.

@remi-gelinas remi-gelinas changed the title ci: NO-ISSUE update supported emacs versions ci: support Emacs 29.2 May 7, 2024
@remi-gelinas
Copy link
Collaborator

Just to add to this actually, I just split out the Emacs version list to allow CI to use it to trigger a lint/test change without making the flake source count as well. The new list is located at nix/emacs-versions.nix if you want to add 29.2.

@remi-gelinas remi-gelinas requested a review from a team May 7, 2024 12:28
@purcell
Copy link
Member

purcell commented May 7, 2024

Also there's 29.3 now too. 😁

@remi-gelinas
Copy link
Collaborator

I took the liberty of adding 29.2 and .3 in #26 - I'll close this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants