Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpg-agent: no-allow-external-cache option #6387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cafkafk
Copy link
Member

@cafkafk cafkafk commented Jan 31, 2025

Description

This is a pretty common configuration option, and one that many people
will find useful to discover, specially if they're not using a desktop
environment.

I thought I would add it. It is also useful to have for
pass-secret-service in the future, since you'd likely want to avoid DE
keyrings.

Signed-off-by: Christina Sørensen [email protected]

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@rycee

This is a pretty common configuration option, and one that many people
will find useful to discover, specially if they're not using a window
manager.

I thought I would add it. It is also useful to have for
pass-secret-service in the future, since you'd likely want to avoid DE
keyrings.

Signed-off-by: Christina Sørensen <[email protected]>
master password and may have installed a Pinentry which employs an
additional external cache to implement such a policy. By using this
option the Pinentry is advised not to make use of such a cache and
instead always ask the user for the requested passphrase.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not much familiar with gpg.
is allow-external-cache allowed along with no-allow-external-cache ?

I like the effort to describe the option but I found it a bit long. Can this be summed up by ask pin not to cache password. What if the pin package ignores the request ? does it collide with other options like defaultCacheTtl in which case some warnings might be of interest ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the description directly from gpg-agent, I think that without familiarity with gpg-agent and gpg, it wil likely not make much sense. It cannot be summed up as ask pin not to cache password.

It doesn't collide with other options. I am using it with all the options home manager currently provides.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I'm not aware of an allow-external-cache option, at least it's not present in any documentation https://www.gnupg.org/documentation/manuals/gnupg/Agent-Options.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants