Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: add default value null to programs.git.signing.key #6032

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

folliehiyuki
Copy link
Contributor

Description

Right now, if other signing options are defined without key specified, home-manager switch will fail.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@rycee

Copy link
Contributor

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. When the key is null, GnuPG will decide what signing key to use based on the author of the commit, which in my opinion should be the default behaviour. When one wants to overwrite that, they can set key to a specific signing key.

@teto
Copy link
Collaborator

teto commented Feb 1, 2025

LGTM. Can you rebase to fix CI plz (can't merge without green CI)

@teto teto merged commit dae6d34 into nix-community:master Feb 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants