-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode: add profiles support #5640
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Reputable2722 <[email protected]>
Signed-off-by: Reputable2722 <[email protected]>
Signed-off-by: Reputable2722 <[email protected]>
2ffb644
to
25eadbb
Compare
Signed-off-by: Reputable2722 <[email protected]>
Signed-off-by: Reputable2722 <[email protected]>
Signed-off-by: Reputable2722 <[email protected]>
Signed-off-by: Reputable2722 <[email protected]>
Signed-off-by: Reputable2722 <[email protected]>
It can be merge ? |
Please! |
bump |
Based on the patch from: nix-community#5640 Signed-off-by: John Muchovej <[email protected]>
Is there anything that prevents this PR from being merged? |
Activation fails on my laptop with following errors:
I'm guessing the cause is not quoting the |
Signed-off-by: Reputable2722 <[email protected]>
I've quoted it now, and it works fine for me (on NixOS). I don't have a MacOS machine to test this out, so do let me know. |
Description
This PR adds support for VSCode Profiles, fixing #3822
Pending
home.activation
, to modify~/.config/VSCodium/User/globalStorage/storage.json
(Reason documented).Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC