Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: add profiles support #5640

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Reputable2772
Copy link

@Reputable2772 Reputable2772 commented Jul 16, 2024

Description

This PR adds support for VSCode Profiles, fixing #3822

Pending

  • Add tests.
  • Write a script for home.activation, to modify ~/.config/VSCodium/User/globalStorage/storage.json (Reason documented).
  • Run tests.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@Reputable2772 Reputable2772 marked this pull request as ready for review July 17, 2024 17:05
@mrdev023
Copy link

It can be merge ?

@tarc
Copy link

tarc commented Oct 2, 2024

It can be merge ?

Please!

@coffeeispower
Copy link

bump

jmuchovej added a commit to jmuchovej/forked-home-manager that referenced this pull request Dec 28, 2024
Based on the patch from: nix-community#5640

Signed-off-by: John Muchovej <[email protected]>
@kafaa-dev
Copy link

Is there anything that prevents this PR from being merged?

@zaripych
Copy link

zaripych commented Feb 1, 2025

Activation fails on my laptop with following errors:

jq: error: Could not open file Library/Application: No such file or directory
jq: error: Could not open file Support/Code/User/globalStorage/storage.json: No such file or directory

I'm guessing the cause is not quoting the $file in a few places in this script https://github.com/nix-community/home-manager/pull/5640/files#diff-d351d3b913727ca5b20e65c99e169cc7839b78df568fcb4b50cbda7dd42cd533R317

Signed-off-by: Reputable2722 <[email protected]>
@Reputable2772
Copy link
Author

Activation fails on my laptop with following errors:

jq: error: Could not open file Library/Application: No such file or directory
jq: error: Could not open file Support/Code/User/globalStorage/storage.json: No such file or directory

I'm guessing the cause is not quoting the $file in a few places in this script https://github.com/nix-community/home-manager/pull/5640/files#diff-d351d3b913727ca5b20e65c99e169cc7839b78df568fcb4b50cbda7dd42cd533R317

I've quoted it now, and it works fine for me (on NixOS). I don't have a MacOS machine to test this out, so do let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants