-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to hide deleted comments. #207
Option to hide deleted comments. #207
Conversation
The switch is: ST_CUSTOMIZE_HIDE_DELETED_COMMENTS. Moderators can still view and modify any deleted comments.
2 similar comments
This would generate pages without comments. The only way to avoid that is to excluded deleted comments in the db query. However, both things will break mentions and new comment highlighting within topic lists (and probably more things I can't remember). |
Well, if a comment should be deleted, then it is bad or harmful or useless if viewed by user. So treating them from mention or red-topic to nothing (blank comment) is not a big deal. A topic without comment means it's full of junk/spam etc. There's a title left, and users can still fill it with comments. Acceptable I think. |
Pretty sure there is no data to back that statement up. Reddit does it and it seems to do just fine. Discourse does it as well (or it used to)
I agree. Something that looks like github commits here would be way better. That's something I'll change when I redesign the UI, one day.
No. That won't work as you think it will. Say you delete 5 comments, when you reach 15 comments in that page, there will be a second empty page where those 5 comments should be. There is actually a hack to avoid this, and it's to move comments instead of deleting them. You can move them to a deleted topic. However, as I said before this still breaks mentions (i.e the mention will redirect to an empty page). I happen to like the moderation messages, it was a conscious choice I've taken. It's not just that removing the actual comment is (way) harder to implement. |
Displaying a "This comment was deleted." is same as nothing showed. I would choose to fade it (StackOverflow) or hide it (GitHub). That's more user friendly. How to and how hard it is to implement leaves to you programmers :)
I suggest Google Material Design :) It uses bold contrast, no bored flated for the whole page.
What about filtering before paginatoring in views? Actions mixed in comments and piles of actions harm the readablity. |
As I said, it breaks mentions and other things.
It's important information that adds to the discussion. You can know when a topic is closed, when it's re-opened, etc. I think the current style may be cumbersome, but something like what github does is ok. Even if I would want this (which I don't) it breaks too many things, so it won't happen. |
OK, you decide :) |
I've thought about it a little bit and it may not be that hard to implement. Mentions and bookmarks must be updated when removing a comment. I'd have to check what else needs to be updated. I've open an issue #220 to track this. I'm closing for now. |
Able to hide deleted comments for a clearer page. Moderators can still view and modify any deleted comments.
The switch is: ST_CUSTOMIZE_HIDE_DELETED_COMMENTS.