Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to hide deleted comments. #207

Closed

Conversation

cryptogun
Copy link
Contributor

@cryptogun cryptogun commented Nov 4, 2017

Able to hide deleted comments for a clearer page. Moderators can still view and modify any deleted comments.
The switch is: ST_CUSTOMIZE_HIDE_DELETED_COMMENTS.

The switch is: ST_CUSTOMIZE_HIDE_DELETED_COMMENTS. Moderators can still view and modify any deleted comments.
@coveralls
Copy link

coveralls commented Nov 4, 2017

Coverage Status

Coverage increased (+0.0003%) to 96.977% when pulling aba0b25 on cryptogun:cry/customize/hide_deleted_comments into b46207e on nitely:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 96.977% when pulling aba0b25 on cryptogun:cry/customize/hide_deleted_comments into b46207e on nitely:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 96.977% when pulling aba0b25 on cryptogun:cry/customize/hide_deleted_comments into b46207e on nitely:master.

@nitely
Copy link
Owner

nitely commented Nov 4, 2017

This would generate pages without comments. The only way to avoid that is to excluded deleted comments in the db query. However, both things will break mentions and new comment highlighting within topic lists (and probably more things I can't remember).

@cryptogun
Copy link
Contributor Author

Well, if a comment should be deleted, then it is bad or harmful or useless if viewed by user. So treating them from mention or red-topic to nothing (blank comment) is not a big deal.
I myself find that the yellow highlighted "This comment was deleted..." is more annoying :)
Oh right, the yellow one is Action operation.

A topic without comment means it's full of junk/spam etc. There's a title left, and users can still fill it with comments. Acceptable I think.

@nitely
Copy link
Owner

nitely commented Nov 4, 2017

Well, if a comment should be deleted, then it is bad or harmful or useless if viewed by user.

Pretty sure there is no data to back that statement up. Reddit does it and it seems to do just fine. Discourse does it as well (or it used to)

I myself find that the yellow highlighted "This comment was deleted..." is more annoying :)
Oh right, the yellow one is Action operation.

I agree. Something that looks like github commits here would be way better. That's something I'll change when I redesign the UI, one day.

A topic without comment means it's full of junk/spam etc. There's a title left, and users can still fill it with comments. Acceptable I think.

No. That won't work as you think it will. Say you delete 5 comments, when you reach 15 comments in that page, there will be a second empty page where those 5 comments should be.

There is actually a hack to avoid this, and it's to move comments instead of deleting them. You can move them to a deleted topic. However, as I said before this still breaks mentions (i.e the mention will redirect to an empty page).

I happen to like the moderation messages, it was a conscious choice I've taken. It's not just that removing the actual comment is (way) harder to implement.

@cryptogun
Copy link
Contributor Author

Displaying a "This comment was deleted." is same as nothing showed. I would choose to fade it (StackOverflow) or hide it (GitHub). That's more user friendly. How to and how hard it is to implement leaves to you programmers :)

redesign the UI

I suggest Google Material Design :) It uses bold contrast, no bored flated for the whole page.

every page is empty if 100...s deleted.

What about filtering before paginatoring in views?

Actions mixed in comments and piles of actions harm the readablity.
The way Discuz handle this is, stamp it on the main(first) comment, or fold them below the main comment like comments under StackOverflow answer.

@nitely
Copy link
Owner

nitely commented Nov 4, 2017

What about filtering before paginatoring in views?

As I said, it breaks mentions and other things.

Actions mixed in comments and piles of actions harm the readablity.

It's important information that adds to the discussion. You can know when a topic is closed, when it's re-opened, etc. I think the current style may be cumbersome, but something like what github does is ok.

Even if I would want this (which I don't) it breaks too many things, so it won't happen.

@cryptogun
Copy link
Contributor Author

OK, you decide :)

@nitely nitely mentioned this pull request Nov 4, 2017
@nitely
Copy link
Owner

nitely commented Nov 4, 2017

I've thought about it a little bit and it may not be that hard to implement. Mentions and bookmarks must be updated when removing a comment. I'd have to check what else needs to be updated. I've open an issue #220 to track this.

I'm closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants