[FIX] mat 7.3 support for SPM.mat files #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3650 +/- ##
==========================================
- Coverage 70.83% 70.46% -0.37%
==========================================
Files 1276 1277 +1
Lines 59320 59153 -167
Branches 9826 8590 -1236
==========================================
- Hits 42019 41685 -334
- Misses 16125 16340 +215
+ Partials 1176 1128 -48 ☔ View full report in Codecov by Sentry. |
effigies
reviewed
Oct 4, 2024
| outputs = self._outputs().get() | ||
| pth = os.path.dirname(self.inputs.spm_mat_file) | ||
| outtype = "nii" if "12" in self.version.split(".")[0] else "img" | ||
| spm = sio.loadmat(self.inputs.spm_mat_file, struct_as_record=False) | ||
| spm = load_spm_mat(self.inputs.spm_mat_file, struct_as_record=False) |
There was a problem hiding this comment.
It would be cleaner to break out the functionality you have into its own function and put the try/catch logic here.
Suggested change
| spm = load_spm_mat(self.inputs.spm_mat_file, struct_as_record=False) | |
| try: | |
| spm = sio.loadmat(self.inputs.spm_mat_file, struct_as_record=False) | |
| except NotImplementedError: # Matlab 7.3+ | |
| spm = load_spm_mat(self.inputs.spm_mat_file) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2162
Fixes #3432
List of changes proposed in this PR (pull-request)
sio.loadmatwith a load function specific forSPM.matfiles, so it also supports >2 GB mat 7.3 HDR filestest_run_interfacewhich I also encountered while running the tests