Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do specify filter="tar" when extracting tars #796

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

yarikoptic
Copy link
Member

Situation is complicated is that when extracting .zip shutil.unpack_archive would also pass it and would crash so we need to pass only when extracting tar. And also that kwargs option was added in 3.12, started to be enforced in 3.13 and in 3.14 would be required

Situation is complicated is that when extracting .zip shutil.unpack_archive
would also pass it and would crash so we need to pass only when extracting
tar.  And also that kwargs option  was added in 3.12, started to be enforced
in 3.13 and in 3.14 would be required
@yarikoptic yarikoptic added the patch Increment the patch version when merged label Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.46%. Comparing base (af9a6e3) to head (bf404c8).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
heudiconv/parser.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
+ Coverage   82.44%   82.46%   +0.02%     
==========================================
  Files          42       42              
  Lines        4312     4323      +11     
==========================================
+ Hits         3555     3565      +10     
- Misses        757      758       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic merged commit faaf765 into nipy:master Oct 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant