STY: Apply ruff/refurb rules (FURB)

niworkflows/engine/tests/test_plugin.py

@@ -1,4 +1,5 @@
 import logging
+import operator
 from types import SimpleNamespace
 
 import pytest
@@ -8,10 +9,6 @@
 from ..plugin import MultiProcPlugin
 
 
-def add(x, y):
-    return x + y
-
-
 def addall(inlist):
     import time
 
@@ -28,7 +25,7 @@ def workflow(tmp_path):
 
     # Generate many nodes and claim a lot of memory
     add_nd = pe.MapNode(
-        niu.Function(function=add, input_names=['x', 'y'], output_names=['z']),
+        niu.Function(function=operator.add, input_names=['x', 'y'], output_names=['z']),
         name='add',
         iterfield=['x'],
         mem_gb=0.8,
@@ -39,7 +36,7 @@ def workflow(tmp_path):
 
     # Run without submitting is another code path
     add_more_nd = pe.Node(
-        niu.Function(function=add, input_names=['x', 'y'], output_names=['z']),
+        niu.Function(function=operator.add, input_names=['x', 'y'], output_names=['z']),
         name='add_more',
         run_without_submitting=True,
     )

niworkflows/reports/core.py

@@ -285,7 +285,7 @@
         self.packagename = packagename
         self.subject_id = subject_id
         if subject_id is not None:
-            self.subject_id = subject_id[4:] if subject_id.startswith('sub-') else subject_id
+            self.subject_id = subject_id.removeprefix('sub-')
             self.out_filename = f'sub-{self.subject_id}.html'
 
         # Default template from niworkflows

niworkflows/utils/bids.py

@@ -134,7 +134,7 @@
         participant_label = [participant_label]
 
     # Drop sub- prefixes
-    participant_label = [sub[4:] if sub.startswith('sub-') else sub for sub in participant_label]
+    participant_label = [sub.removeprefix('sub-') for sub in participant_label]
     # Remove duplicates
     participant_label = sorted(set(participant_label))
     # Remove labels not found

niworkflows/utils/tests/test_utils.py

@@ -83,12 +83,13 @@
 
 
 def _gen_skeleton(root):
-    dirs, files = [], []
-    files.append(root / 'file1')
-    files.append(root / '.file2')
-    dirs.append(root / 'subdir1')
-    files.append(dirs[0] / 'file3')
-    files.append(dirs[0] / '.file4')
+    dirs = [root / 'subdir1']
+    files = [
+        root / 'file1',
+        root / '.file2',
+        dirs[0] / 'file3',
+        dirs[0] / '.file4',
+    ]
     for d in dirs:
         d.mkdir()
     for f in files: