Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Replace ported sources with shim imports and deprecation warnings #789

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

oesteban
Copy link
Member

Resolves: #787.

@oesteban oesteban force-pushed the maint/finalize-porting-of-vrs branch 4 times, most recently from 955a4d5 to 48646ee Compare March 12, 2023 20:12
@oesteban oesteban force-pushed the maint/finalize-porting-of-vrs branch from 48646ee to f1adf7e Compare March 12, 2023 20:17
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.90 ⚠️

Comparison is base (c2b8e0f) 63.39% compared to head (f1adf7e) 60.49%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #789      +/-   ##
==========================================
- Coverage   63.39%   60.49%   -2.90%     
==========================================
  Files          49       42       -7     
  Lines        5963     4863    -1100     
  Branches     1170      943     -227     
==========================================
- Hits         3780     2942     -838     
+ Misses       2001     1808     -193     
+ Partials      182      113      -69     
Flag Coverage Δ
reportlettests ∅ <ø> (∅)
unittests 55.01% <ø> (+4.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies
Copy link
Member

effigies commented Mar 12, 2023

I would specifically not like to depend on nireports. I would just deprecate and not shim. We stop fixing things here, and in a year or so we just remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalize the migration of visual elements to NiReports
3 participants