Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Containers report wrong version (revision) #1372

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

oesteban
Copy link
Member

This finally resolves the problem of a wrong version being set in container images.

Resolves: #1354.
Overrides: #1357.

This finally resolves the problem of a wrong version being set in
container images.

Resolves: #1354.
Overrides: #1357.
WORKDIR /tmp/

# Run mriqc by default
ENTRYPOINT ["/opt/conda/bin/mriqc"]
ARG VERSION
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@effigies @mgxd - we should stop filling in the metadata from the command line as an argument and instead query the installed version.

@oesteban oesteban merged commit 97a7327 into master Jan 13, 2025
14 checks passed
@oesteban oesteban deleted the fix/docker-version-final branch January 13, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: puzzling erroneous version reporting in docker
1 participant