[gh383] Upgrade Ruby and Node dependencies #386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyduong1920
requested review from
rosle,
bterone,
byhbt,
carryall,
hanam1ni,
hoangmirs,
longnd,
malparty and
tyrro
as code owners
andyduong1920
force-pushed
the
feature/gh383-update-gem-versions
branch
2 times, most recently
from
4d2b3c8
to
6d2d1ea
Compare
andyduong1920
force-pushed
the
feature/gh383-update-gem-versions
branch
from
f0f6b53
to
210c08e
Compare
andyduong1920
force-pushed
the
feature/gh383-update-gem-versions
branch
from
0978f2d
to
5196d51
Compare
andyduong1920
force-pushed
the
feature/gh383-update-gem-versions
branch
from
85506bb
to
5194d30
Compare
andyduong1920
force-pushed
the
feature/gh383-update-gem-versions
branch
from
9d99c42
to
37c21d2
Compare
andyduong1920
force-pushed
the
feature/gh383-update-gem-versions
branch
from
b6e5cb2
to
fa23d86
Compare
andyduong1920
force-pushed
the
feature/gh383-update-gem-versions
branch
from
47c520c
to
0f1e99e
Compare
|
I'm closing this PR and will open the new separate PR it it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #383
What happened 👀
Upgrade Ruby, Rails and some Node dependencies
1/ Ruby -> 3.2.2
2/ Rails -> 7.0.6
3/ Node -> 18.16.1
4/ Redis -> 7.0.11
Insight 📝
@nimblehq/stylelint-config-nimbleas it doesn't compatible with Node 18 LTS yet, need to wait for the new release from the team@nimblehq/eslint-config-nimbleas well as that version doesn't compatible with Node 18 LTS as well, and seems the team might move to use@nimblehq/eslint-config-nimble-coreinstead - but the@nimblehq/eslint-config-nimble-corerequires some TypeScript Lint topic, I will create a new issue for thisnpm set-scripttonpm pkg setas it was deprecated in the new npm cli version (we are at npm 9.x)Proof Of Work 📹
On the file changes tab and the test is passed