Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt blocks in ccgstmts to cbuilder #24416

Merged
merged 5 commits into from
Nov 8, 2024
Merged

adapt blocks in ccgstmts to cbuilder #24416

merged 5 commits into from
Nov 8, 2024

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Nov 7, 2024 •
edited
Loading

This loses indents in codegen for now, another PR includes changes to add indents to Builder itself rather than tracking TBlock: #24418

@metagn
Copy link
Collaborator Author

metagn commented Nov 7, 2024 •
edited
Loading

Diff for adding indents is too large, will open separate PR for them instead. Edit: #24418

@metagn metagn marked this pull request as ready for review November 7, 2024 22:29
@metagn metagn mentioned this pull request Nov 7, 2024
Merged
@Araq Araq merged commit b3c1fba into nim-lang:devel Nov 8, 2024
18 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from b3c1fba

Hint: mm: orc; opt: speed; options: -d:release
177176 lines; 8.668s; 652.801MiB peakmem

@metagn metagn mentioned this pull request Nov 8, 2024
Merged
Araq pushed a commit that referenced this pull request Nov 9, 2024
@metagn
cbuilder: most of ccgstmts (#24420)
8091d76 
This adapts most of ccgstmts to cbuilder, missing C++ exceptions and
`genCaseGeneric`/`genIfForCaseUntil`. Rebased version of #24399 which
was split into some other PRs and since has had conflicts with #24416.
Araq pushed a commit that referenced this pull request Nov 12, 2024
@metagn
add indents to cbuilder (#24418)
1863f64 
Follows #24416

Really only shows benefits if most of ccgstmts is done as in
#24399/#24420, but the diff is entirely in cbuilder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metagn @Araq