Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #24379; better error messages for ill-formed type symbols from macros #24380

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

ringabout
Copy link
Member

fixes #24379

@ringabout ringabout changed the title fixes #24379; better error messages for ill-formed type symbols fixes #24379; better error messages for ill-formed type symbols from macros Oct 29, 2024
@Araq Araq merged commit d618974 into devel Oct 29, 2024
22 checks passed
@Araq Araq deleted the ringabout-patch-11 branch October 29, 2024 14:32
@Araq
Copy link
Member

Araq commented Oct 29, 2024

Ping @narimiran I think this can be backported safely.

Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from d618974

Hint: mm: orc; opt: speed; options: -d:release
176070 lines; 9.151s; 655.137MiB peakmem

narimiran pushed a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIGSEGV with nim c -c and nim e on macro w(): untyped = result = genSym(nskType)
2 participants