Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix dedicated server build #322

Merged
merged 3 commits into from
Dec 13, 2023
Merged

[Windows] Fix dedicated server build #322

merged 3 commits into from
Dec 13, 2023

Conversation

dimhotepus
Copy link
Contributor

Dedicated server is not build on Windows, see CI log:

https://github.com/nillerusr/source-engine/actions/runs/7013944669/job/19080884554

sys_ded.cpp.5.o : error LNK2001: unresolved external symbol "public: virtual int __cdecl CTextConsoleWin32::GetWidth(void)" (?GetWidth@CTextConsoleWin32@@UEAAHXZ)

sys_ded.cpp.5.o : error LNK2001: unresolved external symbol "public: virtual void __cdecl CTextConsoleWin32::SetVisible(bool)" (?SetVisible@CTextConsoleWin32@@UEAAX_N@Z)

sys_ded.cpp.5.o : error LNK2001: unresolved external symbol "char * gpszCvars" (?gpszCvars@@3PEADEA)

basefilesystem.cpp.5.o : error LNK2019: unresolved external symbol __imp_SHGetFileInfoW referenced in function "public: virtual bool __cdecl CBaseFileSystem::GetFileTypeForFullPath(char const *,wchar_t *,unsigned __int64)" (?GetFileTypeForFullPath@CBaseFileSystem@@UEAA_NPEBDPEA_W_K@Z)

sys_windows.cpp.5.o : error LNK2019: unresolved external symbol __imp_PostQuitMessage referenced in function "public: virtual void __cdecl CSys::ErrorMessage(int,char const *)" (?ErrorMessage@CSys@@UEAAXHPEBD@Z)

sys_windows.cpp.5.o : error LNK2019: unresolved external symbol __imp_CommandLineToArgvW referenced in function DedicatedMain

sys_windows.cpp.5.o : error LNK2019: unresolved external symbol "void __cdecl VGUIPrintf(char const *)" (?VGUIPrintf@@YAXPEBD@Z) referenced in function "public: virtual void __cdecl CSys::ConsoleOutput(char *)" (?ConsoleOutput@CSys@@UEAAXPEAD@Z)

D:\a\source-engine\source-engine\build\dedicated\dedicated.dll : warning LNK4088: image being generated due to /FORCE option; image may not run

/FORCE option hides linker errors and result image is not runnable.

Now it should be fixed.

Closes #310

@dimhotepus dimhotepus changed the title Fix build of dedicated server on Windows [Windows] Fix dedicated server build Dec 2, 2023
nillerusr added a commit that referenced this pull request Dec 13, 2023
This is using to override debug crt functions.
Does anyone actually use this?
@nillerusr
Copy link
Owner

  File "/home/runner/work/source-engine/source-engine/dedicated/wscript", line 63
    if bld.env.DEST_OS == 'win32':
                                 ^
TabError: inconsistent use of tabs and spaces in indentation

Cool, you(or your IDE) used spaces instead of tabs.

@nillerusr nillerusr linked an issue Dec 13, 2023 that may be closed by this pull request
nillerusr added a commit that referenced this pull request Dec 13, 2023
@nillerusr nillerusr merged commit 327ea9d into nillerusr:master Dec 13, 2023
14 of 16 checks passed
@dimhotepus dimhotepus deleted the fix-dedicated-build branch December 13, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't build dedicated server (dedicated.dll) for windows [Windows] Debug dedicated server crash on startup
2 participants