Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sendgrid: Allow to specify the content type #871

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

firefart
Copy link

@firefart firefart commented Sep 19, 2024

Description

Previously the Content-Type was hardcoded to text/html. This enables the use of text/plain like in the mail service.
Also the sendgrid library now has a SendWithContext method which makes the code simpler.

Motivation and Context

It's now possible to send plain text emails

How Has This Been Tested?

Sending an email through sendgrid. Most of the code was copied over from the mail service where the same functionality already exists.

Screenshots / Output (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant