Fix error when parsing UCI options #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex that splits a UCI option into parts did not include word boundries, so words like "mini" would be split into "min" and "i", leading to parse errors. This commit puts word boundries into the regex to fix this. Fixes niklasf#1112
|
Looks good. Let's also add a test for this. |
|
Test added that passes with this PR and fails on master. |
Test uses fairy-stockfish since that engine revealed the original bug.
|
Not yet. I need to add fairy-stockfish to the test installation. |
|
We could also use MockTransport with output from fairy-stockfish. |
|
Do you want to keep both tests or should I delete the fairy-stockfish test to reduce the external dependencies? |
|
I can confirm that this fixes my test case. |
|
Let's keep it for now, since you already wrote the installation script and it looks like it should be pretty stable. Thank you, both! |
|
@niklasf Are you planning a 1.11.1 release with this fix or will we have to wait until 2.0? |
niklasf
added a commit
that referenced
this pull request
Oct 9, 2024
Fix error when parsing UCI options
|
I suppose 2.0.0 may be quite a while out, so published 1.11.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex that splits a UCI option into parts did not include word boundries, so words like "mini" would be split into "min" and "i", leading to parse errors. This commit puts word boundries into the regex to fix this.
Fixes #1112