fix(bfdr): fix birth specific properties #209
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Fetal Death, there are some birth-specific properties that should not be present on the fetal death side but are because those properties are in the common NatalityRecord class. This became apparent when viewing a Fetal Death Record in Canary.
This resulted in several duplicates such as:
ChildGivenName
andFetusGivenName
DateOfBirth
vsDateOfDelivery
There are still questions for some properties to answer. For instance:
PlaceOfBirth
is at the NatalityRecord level, but Fetal Death Records also havePlaceOfDelivery
. But the implementations are very different. But they probably shouldn't both be in FetalDeath. How should this be resolved?