Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bfdr): fix birth specific properties #209

Closed
wants to merge 5 commits into from

Conversation

RobertScalfani
Copy link
Contributor

@RobertScalfani RobertScalfani commented Dec 30, 2024

For Fetal Death, there are some birth-specific properties that should not be present on the fetal death side but are because those properties are in the common NatalityRecord class. This became apparent when viewing a Fetal Death Record in Canary.
This resulted in several duplicates such as:

  • ChildGivenName and FetusGivenName
  • DateOfBirth vs DateOfDelivery

There are still questions for some properties to answer. For instance:

  • PlaceOfBirth is at the NatalityRecord level, but Fetal Death Records also have PlaceOfDelivery. But the implementations are very different. But they probably shouldn't both be in FetalDeath. How should this be resolved?

Copy link

Code Coverage

Package Line Rate Branch Rate Health
BFDR.Messaging 59% 44%
VitalRecord 61% 81%
BFDR 91% 87%
VitalRecord.Messaging 69% 64%
Summary 72% (10961 / 15142) 82% (3473 / 4220)

@RobertScalfani RobertScalfani changed the title fix (bfdr): fix birth specific properties fix(bfdr): fix birth specific properties Dec 30, 2024
@smacadam
Copy link
Contributor

smacadam commented Jan 3, 2025

There are still questions for some properties to answer. For instance:

  • PlaceOfBirth is at the NatalityRecord level, but Fetal Death Records also have PlaceOfDelivery. But the implementations are very different. But they probably shouldn't both be in FetalDeath. How should this be resolved?

Looking at the IG, PlaceOfBirth is used for the jurisdiction ID for both Birth (BSTATE) and Fetal Death (DSTATE). They have the same implementation so it makes sense to reuse the same code, but the name "PlaceOfBirth" isn't very consistent with FetalDeath. Maybe the names should change to BirthLocationJurisdiction and DeliveryLocationJurisdiction. This would be consistent with VRDR's "DeathLocationJurisdiction".

PlaceOfDelivery is the address location and is specific to FetalDeath. I'd say PlaceOfDelivery remains as is since it's very different from the other fields.

Other changes look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants