Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vr): fix time based partial date times #208

Merged
merged 12 commits into from
Jan 22, 2025
Merged

fix(vr): fix time based partial date times #208

merged 12 commits into from
Jan 22, 2025

Conversation

RobertScalfani
Copy link
Contributor

@RobertScalfani RobertScalfani commented Dec 27, 2024 •
edited
Loading

No description provided.

@RobertScalfani RobertScalfani changed the title fix (vr): fix time based partial date times fix(vr): fix time based partial date times Dec 30, 2024
@smacadam
Copy link
Contributor

smacadam commented Jan 3, 2025

Add tests to confirm the changes address the issue described in the ticket:
"There's an issue where Dates are doubly converted to/from DateTimes for PartialDate fields. This loses some data. Fix this by creating a Date version of the date formatting methods."

@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
VitalRecord 61% 82% ➖
VitalRecord.Messaging 69% 64% ➖
BFDR.Messaging 59% 44% ➖
BFDR 91% 87% ✔
Summary 72% (11012 / 15194) 82% (3524 / 4280) ➖

@smacadam smacadam merged commit 97d82ec into main Jan 22, 2025
4 checks passed
@smacadam smacadam deleted the pdt-fixes branch January 22, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smacadam smacadam smacadam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertScalfani @smacadam