Revert "Revert "NVSS 509: Made destination endpoint validation case i…

…nsensitive""
nightingaleproject · Nov 2, 2023 · d2edb3f · d2edb3f
1 parent 96df967
commit d2edb3f
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/messaging.tests/Integration/BundlesControllerTests.cs b/messaging.tests/Integration/BundlesControllerTests.cs
@@ -557,6 +557,23 @@ public async void PostNCHSIsInDestinationEndpointList()
             Assert.Equal(HttpStatusCode.NoContent, createSubmissionMessage.StatusCode);
         }
 
+        [Fact]
+        public async void PostNCHSIsInDestinationEndpointListUppercase()
+        {
+            // Clear any messages in the database for a clean test
+            DatabaseHelper.ResetDatabase(_context);
+
+            // Create a new empty Death Record WITH nchs in the endpoint list
+            DeathRecordSubmissionMessage recordSubmission = new DeathRecordSubmissionMessage(new DeathRecord());
+            recordSubmission.JurisdictionId = "MA";
+            recordSubmission.MessageSource = "http://example.fhir.org";
+            recordSubmission.CertNo = 1;
+            recordSubmission.MessageDestination = "temp,http://nchs.CDC.gov/VRDR_Submission,temp";
+            // Submit that Death Record
+            HttpResponseMessage createSubmissionMessage = await JsonResponseHelpers.PostJsonAsync(_client, $"/MA/Bundle", recordSubmission.ToJson());
+            Assert.Equal(HttpStatusCode.NoContent, createSubmissionMessage.StatusCode);
+        }
+
         [Fact]
         public async void PostCatchMissingId()
         {

diff --git a/messaging/Controllers/BundlesController.cs b/messaging/Controllers/BundlesController.cs
@@ -494,7 +494,8 @@ private bool validateNCHSDestination(string destination)
             List<string> destinationEndpoints = destination.Split(',').ToList();
             foreach (string d in destinationEndpoints)
             {
-                switch (d)
+                // set the message destination to lowercase to make the url validation case-insensitive
+                switch (d.ToLower())
                 {
                     case "http://nchs.cdc.gov/vrdr_acknowledgement":
                     case "http://nchs.cdc.gov/vrdr_alias":