Engine is now aware of being reloaded #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When game was resumed, Engine::onUpdate(pNanosecondsElapsed) was called with unusually big value of pNanosecondsElapsed. This caused Box2D simulation instability or undesired behavior of particle systems. This patch fixes this issue by adding lag awarness to the Engine. Vertex, Texture and Font managers will return true from theirs update* method if feeling guilty of unusually long execution time (due to reloading).
|
This change can be made smaller if you do not like that it changes *Manager classes. Just let me know what you want to have changed. |
|
Great fix! No more problems with my particle systems when resuming since I added this. Thanks |
|
Apparently there is something wrong with it, and Nicolas does not want to say what it is... :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When game was resumed, Engine::onUpdate(pNanosecondsElapsed)
was called with unusually big value of pNanosecondsElapsed.
This caused Box2D simulation instability or undesired behavior of particle systems.
This patch fixes this issue by adding lag awarness to the Engine.
Vertex, Texture and Font managers will return true from theirs update* method
if feeling guilty of unusually long execution time (due to reloading).