Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Added HTML Outputter #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

scribblemaniac
Copy link

To keep things simple, this outputter class just puts the JsonOutputter output into a string variable and Javascript handles the rest. Currently Javascript generates an interactive box and whisker plot of the data with plotly. By hovering over the elements you can get all the data your would normally see from console output (and then some), so I did not deem it necessary to add a text based output to the webpage.

Closes #21

@Zikoel
Copy link

Zikoel commented Aug 28, 2017

Someone can resolve this conflicts? This features can be very useful!

@scribblemaniac
Copy link
Author

@Zikoel I just resolved the conflict but you'll probably have to pull my branch if you want to use the feature. This change would have been merged long ago if this repo wasn't dead.

@Zikoel
Copy link

Zikoel commented Aug 30, 2017

@scribblemaniac Why the repo is dead? Is There something Alternative? I like this project and I think it can be useful! I know that is a little bit old but I use it and it do its job well!

@nickbruun
Copy link
Owner

nickbruun commented Aug 30, 2017

This isn't dead. This simply isn't the solution I wanted, but I quite simply haven't been able to get around to it yet. I very much appreciate the effort, though :) Let me try to get around to looking at this in the next month or so when I'm in a position to do so.

@scribblemaniac
Copy link
Author

I see. Well there are few other conclusions one can draw when their PR sits open for over a year with absolutely no feedback. It would be useful to know why this isn't good enough to be merged. Certainly this is better than the no html output you have now?

@nickbruun
Copy link
Owner

The annoyingly simple answer to this is that I hadn't had the time to get to it for reasons that are beyond discussing here. The idea behind wanting to have an HTML output is to have something more equivalent to the console output, where you can see a breakdown for each benchmark. Further to this, I do want us to be able to set up comparative reports to be output based on multiple runs, but that is beyond the scope for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants