-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix discard ratio and maxSuccess interacting poorly #371
Conversation
small + fix `withMaxSuccess` not updating result on discard
@Rewbert thoughts? |
This whole discard thing is such a thorn in my side. The choice to compute sizes in this way seems to have been arbitrarily chosen initially (Koen looked guilty when I asked him about this!), so in my mind this is "equally arbitrary". I have thought a lot about this, and have even tried out a few different approaches altogether, but have not landed in anything that is obviously superior. I think the question of sizes might be a more complicated one than it appears initially. Regarding the eventual future merge of the parallel branch, this will not impact me negatively. |
Co-authored-by: Ulf Norell <[email protected]>
regardless of if we are using `withMaxSuccess` and `withDiscardRatio` or `stdArgs{maxSuccess=...,maxDiscardRatio=...}`
[no ci]
For posterity, I had to factor out |
Fixes #338