Fix

nicelocal · Dec 1, 2023 · edf2d1e · edf2d1e
1 parent 7e94841
commit edf2d1e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 14 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Block/IfElse/IfAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Block/IfElse/IfAnalyzer.php
@@ -272,20 +272,6 @@ public static function analyze(
                 array_keys($if_scope->negated_types),
             );
 
-            $extra_vars_to_update = [];
-
-            // if there's an object-like array in there, we also need to update the root array variable
-            foreach ($vars_to_update as $var_id) {
-                $bracked_pos = strpos($var_id, '[');
-                if ($bracked_pos !== false) {
-                    $extra_vars_to_update[] = substr($var_id, 0, $bracked_pos);
-                }
-            }
-
-            if ($extra_vars_to_update) {
-                $vars_to_update = array_unique(array_merge($extra_vars_to_update, $vars_to_update));
-            }
-
             $outer_context->update(
                 $old_if_context,
                 $if_context,

diff --git a/tests/TypeReconciliation/ArrayKeyExistsTest.php b/tests/TypeReconciliation/ArrayKeyExistsTest.php
@@ -56,6 +56,19 @@ function getMethodName(array $data = []): void {
                     }
                 ',
             ],
+            'arrayKeyExistsNoSideEffects' => [
+                'code' => '<?php
+                    function getMethodName(array $ddata = []): void {
+                        if (\array_key_exists("redirect", $ddata)) {
+                            return;
+                        }
+                        if (random_int(0, 1)) {
+                            $ddata["type"] = "test";
+                        }
+                        /** @psalm-check-type-exact $ddata = array<array-key, mixed> */
+                    }
+                '
+            ]
             'arrayKeyExistsTwice' => [
                 'code' => '<?php
                     function two(array $a): void {