Skip to content

Commit

Permalink
Don't make Config final after all
Browse files Browse the repository at this point in the history
  • Loading branch information
danog committed Nov 13, 2023
1 parent 3926847 commit 3491169
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 15 deletions.
15 changes: 1 addition & 14 deletions psalm-baseline.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="dev-master@292ed063233e29d59d0bde61bb6daedee94d55bb">
<files psalm-version="dev-master@3926847a0fc6028ad82268af0726188bd0bf0a7e">
<file src="examples/TemplateChecker.php">
<PossiblyUndefinedIntArrayOffset>
<code><![CDATA[$comment_block->tags['variablesfrom'][0]]]></code>
Expand All @@ -16,9 +16,6 @@
<PossiblyNullArgument>
<code>$deprecated_element_xml</code>
</PossiblyNullArgument>
<PropertyTypeCoercion>
<code>$this</code>
</PropertyTypeCoercion>
</file>
<file src="src/Psalm/Config/FileFilter.php">
<PossiblyUndefinedIntArrayOffset>
Expand Down Expand Up @@ -625,16 +622,6 @@
<code>hasLowercaseString</code>
</PossiblyUnusedMethod>
</file>
<file src="tests/TestConfig.php">
<InvalidExtendClass>
<code>Config</code>
</InvalidExtendClass>
<MethodSignatureMismatch>
<code>public function __construct()</code>
<code>public function getComposerFilePathForClassLike(string $fq_classlike_name): bool</code>
<code>public function getProjectDirectories(): array</code>
</MethodSignatureMismatch>
</file>
<file src="vendor/nikic/php-parser/lib/PhpParser/Node/Expr/ArrowFunction.php">
<PossiblyUndefinedStringArrayOffset>
<code><![CDATA[$subNodes['expr']]]></code>
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Config.php
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
* @psalm-suppress PropertyNotSetInConstructor
* @psalm-consistent-constructor
*/
final class Config
class Config
{
private const DEFAULT_FILE_NAME = 'psalm.xml';
final public const CONFIG_NAMESPACE = 'https://getpsalm.org/schema/config';
Expand Down

0 comments on commit 3491169

Please sign in to comment.