[Core] Remove ##__VA_ARGS__
#150
Merged
+122
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FintasticMan
force-pushed
the
remove-gnu-vararg-ext
branch
from
cf4605a to
6194963
Compare
|
Rebased due to conflicts. Edit: again |
FintasticMan
force-pushed
the
remove-gnu-vararg-ext
branch
from
6194963 to
6694626
Compare
|
I'll be fixing the conflicts in the coming days |
This removes the need for ##__VA_ARGS__.
nicbarker
force-pushed
the
remove-gnu-vararg-ext
branch
from
6694626 to
0cd92ec
Compare
FintasticMan
commented
Jan 10, 2025
nicbarker
pushed a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #135.
Removes the use of the GNU extension
##__VA_ARGS__. There were 2 (technically 3) usages of it:CLAY: based on the poll I sent in the Discord, callingCLAYwith no parameters is very uncommon, and if it is needed, you can just useCLAY(0).CLAY_SIZING_{FIT,GROW}: These macros took a struct before for the min and max, this changes it to take min and max as separate parameters, where max is optional. This also more accurately matches what it says in the README.