Skip to content

Commit

Permalink
Fix bug in Clay_SetPointerState that causes null pointer deref (#33)
Browse files Browse the repository at this point in the history
  • Loading branch information
SogoCZE authored Oct 2, 2024
1 parent 948b7ce commit 987e7fd
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions clay.h
Original file line number Diff line number Diff line change
Expand Up @@ -3091,8 +3091,9 @@ void Clay_SetPointerState(Clay_Vector2 position, bool isPointerDown) {
Clay__treeNodeVisited.internalArray[dfsBuffer.length - 1] = true;
Clay_LayoutElement *currentElement = Clay_LayoutElementArray_Get(&Clay__layoutElements, Clay__int32_tArray_Get(&dfsBuffer, (int)dfsBuffer.length - 1));
Clay_LayoutElementHashMapItem *mapItem = Clay__GetHashMapItem(currentElement->id); // TODO I wish there was a way around this, maybe the fact that it's essentially a binary tree limits the cost, have to measure
if ((mapItem && Clay__PointIsInsideRect(position, mapItem->boundingBox)) || (!mapItem && Clay__PointIsInsideRect(position, CLAY__INIT(Clay_BoundingBox) {0,0, currentElement->dimensions.width, currentElement->dimensions.height}))) {
if (mapItem && Clay__PointIsInsideRect(position, mapItem->boundingBox)) {
Clay__ElementIdArray_Add(&Clay__pointerOverIds, mapItem->elementId);

if (currentElement->elementType == CLAY__LAYOUT_ELEMENT_TYPE_TEXT) {
dfsBuffer.length--;
continue;
Expand Down Expand Up @@ -3343,4 +3344,4 @@ freely, subject to the following restrictions:
3. This notice may not be removed or altered from any source
distribution.
*/
*/

0 comments on commit 987e7fd

Please sign in to comment.