Add check_protos workflow to validate that all .proto files in the repo are valid #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
requested changes
Nov 8, 2023
bkeryan
reviewed
Nov 8, 2023
bkeryan
reviewed
Nov 8, 2023
bkeryan
reviewed
Nov 8, 2023
…ult processing for _check_protos.py etc.
bkeryan
requested changes
Nov 9, 2023
bkeryan
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Runs a script on the PR to validate that all .proto files can compile with protoc.
Why should this Pull Request be merged?
Ensure that .proto files checked in have a valid format and that they have their dependencies met for their imports in the repo.
What testing has been done?
None. This PR should run the check_protos workflow and it should fail until we add some dependent .protos into the repo.