Skip to content

Commit

Permalink
Address Brad's comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
ccaltagi committed Mar 19, 2024
1 parent 7140c4f commit de64767
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 7 deletions.
10 changes: 5 additions & 5 deletions ni/protobuf/types/precision_timestamp.proto
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,16 @@ option php_namespace = "NI\\PROTOBUF\\TYPES";
option ruby_package = "NI::Protobuf::Types";

// A PrecisionTimestamp represents a point in time expressed in NI Binary Time Format (NI-BTF).
// https://www.ni.com/docs/en-US/bundle/labwindows-cvi/page/cvi/libref/ni-btf.htm
// NI-BTF stores time values in Coordinated Universal Time (UTC) format.
// A PrecisionTimestamp is encoded as a count of seconds and fractions of seconds at
// 2 exp(-64) resolution. The count is relative to an epoch at UTC midnight on
// January 1, 1904, Universal Time.
// 2^-64 resolution. The count is relative to an epoch of January 1, 1904.
message PrecisionTimestamp
{
// Represents seconds of UTC time since epoch
// Represents the number of seconds since the epoch
// 1904-01-01T00:00:00Z.
int64 seconds = 1;
// Non-negative fractions of a second at 2 exp(-64) resolution.

// Non-negative fractions of a second at 2^-64 resolution.
uint64 fractional_seconds = 2;
}
10 changes: 8 additions & 2 deletions ni/protobuf/types/waveform.proto
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,21 @@ message DoubleWaveform
{
// The trigger time of the waveform.
PrecisionTimestamp t0 = 1;

// The time interval in seconds between data points in the waveform.
double dt = 2;

// The data values of the waveform.
repeated double y_data = 3;

// The names and values of all waveform attributes.
// A waveform attribute is metadata attached to a waveform.
// It is represented in this message as a map associating the name of the attribute with the value described by WaveformAttributeValue.
// The NI-DAQ driver sets the following string attributes:
// NI_DeviceNumber: the device number of the hardware device producing the waveform.
// The NI-DAQmx driver sets the following string attributes:
// NI_ChannelName: the name of the virtual channel producing the waveform.
// NI_LineNames: the name of the digital line in the waveform.
// NI_UnitDescription: the units of measure for the waveform.
// NI_dBReference: the reference value to use when converting measurement levels to decibel.
// For additional information on waveform attributes, please visit https://www.ni.com/docs/en-US/bundle/labview-api-ref/page/functions/get-waveform-attribute.html
map<string, WaveformAttributeValue> attributes = 4;
}
Expand All @@ -48,10 +51,13 @@ message WaveformAttributeValue
{
// Represents a bool attribute.
bool bool_value = 1;

// Represents an integer attribute.
int32 integer_value = 2;

// Represents a double attribute.
double double_value = 3;

// Represents a string attribute.
string string_value = 4;
}
Expand Down

0 comments on commit de64767

Please sign in to comment.