Remove ttlStrategy from systemlink starter template #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CiprianAnton
commented
May 16, 2024
CiprianAnton
requested review from
JD-Robertson,
prestwick,
BKnight760,
lnowotny,
Christian-Nunnally and
MelissaHilliard
as code owners
MileaRobertStefan
approved these changes
May 16, 2024
JD-Robertson
approved these changes
May 28, 2024
CiprianAnton
deleted the
users/canton/update-starter-template-regarding-nbexec-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Update starter-template values for notebook execution
Why should this Pull Request be merged?
The new helm charts comes with a different ttl strategy, where secondsAfterCompletion is being set to avoid workflows in error state not being cleaned up.
Also those setttings are mentioned in public doc: https://www.ni.com/docs/en-US/bundle/systemlink-enterprise/page/configuring-the-notebook-exectution-service.html
What testing has been done?
Tested in internal clusters.