Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Add SetRuntimeEnvironment call for NI-DCPower #962

Closed
wants to merge 8 commits into from
Closed

RFC: Add SetRuntimeEnvironment call for NI-DCPower #962

wants to merge 8 commits into from

Commits on Jul 15, 2023

  1. Add setRuntimeEnvironment as a private NI-DCPower function

    @ni-jfitzger
    ni-jfitzger committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    fbe8af2 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Call SetRuntimeEnvironment

    @ni-jfitzger
    ni-jfitzger committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    3d582a3 View commit details
    Browse the repository at this point in the history

  2. Use FILEVERSION, instead

    @ni-jfitzger
    ni-jfitzger committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    3bdebe4 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Address Feedback: 

    * Use constexpr to avoid codebloat
* Follow naming conventions
* Eliminate unused constants
* Add comment to CMakeLists.txt
    @ni-jfitzger
    ni-jfitzger committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    6187736 View commit details
    Browse the repository at this point in the history

  2. Conditionally call SetRuntimeEnvironment

    @ni-jfitzger
    ni-jfitzger committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    2e7c120 View commit details
    Browse the repository at this point in the history

  3. Make constants static, just in case

    @ni-jfitzger
    ni-jfitzger committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    e56b3a2 View commit details
    Browse the repository at this point in the history

  4. Conditionally include version.h

    @ni-jfitzger
    ni-jfitzger committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    6eb1120 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Fix argument order

    @ni-jfitzger
    ni-jfitzger committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    310ac3f View commit details
    Browse the repository at this point in the history