Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS-571 Update HouseKeeping Security Group #74

Merged
merged 4 commits into from
Jan 16, 2024
Merged

DS-571 Update HouseKeeping Security Group #74

merged 4 commits into from
Jan 16, 2024

Conversation

kayodewale
Copy link
Contributor

Updated the Housekeeping Security group for nonprod, put and Live Profiles.
Also, updated the role used for the Non-Production Pipeline.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kayodewale kayodewale marked this pull request as ready for review December 21, 2023 15:02
@kayodewale kayodewale requested a review from a team as a code owner December 21, 2023 15:02
kayodewale
kayodewale commented Dec 21, 2023
View reviewed changes
Copy link
Contributor Author

@kayodewale kayodewale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stage 1 needs to go in first before this Change as this is Stage 2

@kayodewale kayodewale self-assigned this Dec 21, 2023
@kayodewale kayodewale added the dependencies Pull requests that update a dependency file label Dec 21, 2023
swestbro1
swestbro1 approved these changes Dec 21, 2023
View reviewed changes
Copy link

@swestbro1 swestbro1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@forjayssake forjayssake merged commit 8b32968 into main Jan 16, 2024
12 of 15 checks passed
@forjayssake forjayssake deleted the develop branch January 16, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swestbro1 swestbro1 swestbro1 approved these changes

@forjayssake forjayssake forjayssake approved these changes

Assignees

@kayodewale kayodewale

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kayodewale @forjayssake @swestbro1