-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PriceClass variable so that it is configurable #19
Conversation
Signed-off-by: Thomas Judd-Cooper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There's no specific place in the config to place this outside of the root variables to place S3 config, so might be worth some sort of refactor in the future to expose a few more options.
Yes, a refactor might be prudent - this was a non-breaking change that could add this sort of functionality for now. Seems a good compromise for the time being :-). |
@andylamp These changes failed to merge due to the histories now being a little off. |
@Tomdango yes, let me do that in a bit. Closing the PR and I'll open a new one. |
Description
This PR adds a
price_class
variable so that the respective CDN optimization can be set within the scope of the CloudFront distribution being created. Currently this is not supported and its value is hardcoded to some regions (instead of all).Additionally, it allows the configuration of the cache policy that the distribution will use as this is currently this is not supported.
This PR addresses these limitations and introduces no breaking changes.
Context
Allow users to adjust the following parameters,
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.