feat: make nonce handling configurable #111
Conversation
bvogel
changed the title
|
OmniAuth and its plugins are Rack middleware and do not require Rails. I see that there are some rails specific extensions being used in this PR which will break when Rails is not available. |
|
@btalbot Thanks for pointing that out. I'll look into ways to interact with cookies without the rails intermediate layer. But as the rails dependency is only required in testing would it be fine to keep it as dev dependency only? |
|
Seems like the best way to ensure that rails extensions are not present is to not include them in any dependency; otherwise, how can you be sure? |
|
@bvogel thanks for your work on this. spent 2 hours trying to debug this issue and finally found this. I hope this gets merged 🙏 |
|
works for me! currently I see no way to effectively use the gem without this addition |
This PR will introduce a individual handling of the nonce validation that is significantly hindered by Apple with using a POST callback.
Added specs, README too.
fixes #102 and
fixes #103
Just reopening #107 with an additional fix.
See all discussion over there.