feat: revised hover effect #1171
Conversation
Co-authored-by: Tamal Das <[email protected]>
…ity#1140) * fix: fixed functioning of contact us button in footer * fix: applied font-families and colors in modal * fix: fallback fonts * fix: fallback fonts * fix: fallback fonts --------- Co-authored-by: Tamal Das <[email protected]>
WalkthroughThe changes across various files in the codebase include updates to documentation, code cleanup, and UI enhancements. A hyperlink was added to the README for better accessibility, Docker setup instructions were made more specific, and an API endpoint was corrected. CSS styles were updated for hover effects and font families, and unnecessary code was removed from components. The Changes
Assessment against linked issues
TipsChat with CodeRabbit Bot (
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @dhananjay-Byte, thank you for raising a pull request.
Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.
Feel free to reach out to Tamal on Twitter, or drop a mail at [email protected] if you think that this pull request is of critical priority.
Give us a ⭐ to show some support
Happy OpenSource 🚀
github-actions
bot
added
hacktoberfest-accepted
This comment was marked as off-topic.
This comment was marked as off-topic.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (11)
- README.md (1 hunks)
- docs/DockerSetup.md (1 hunks)
- src/assets/data/ApiEndpoints.js (1 hunks)
- src/components/Banners/Banner.css (2 hunks)
- src/components/Banners/HomeBanner.jsx (1 hunks)
- src/components/Banners/Milaninfobanner.jsx (4 hunks)
- src/components/Button/GlobalButton/Button.module.css (1 hunks)
- src/components/Footer/Footer.css (1 hunks)
- src/components/Footer/Footer.jsx (2 hunks)
- src/components/Modal/Modal.jsx (2 hunks)
- src/service/MilanApi.js (1 hunks)
Files skipped from review due to trivial changes (7)
- README.md
- docs/DockerSetup.md
- src/assets/data/ApiEndpoints.js
- src/components/Banners/HomeBanner.jsx
- src/components/Banners/Milaninfobanner.jsx
- src/components/Button/GlobalButton/Button.module.css
- src/components/Footer/Footer.jsx
Additional comments: 4
src/components/Modal/Modal.jsx (1)
- 4-8: The removal of
createPortalusage suggests a significant change in how the modal is rendered. Ensure that this change does not affect the modal's behavior, especially in terms of accessibility and positioning in the DOM. If the modal was previously being rendered in a specific part of the DOM to ensure proper stacking and accessibility, this change might need to be reconsidered.src/service/MilanApi.js (1)
- 103-112: The change from a GET to a POST request for the
Logoutfunction is a significant alteration in how the logout functionality is implemented. This should be verified to ensure that it aligns with the backend expectations and that the backend endpoint supports POST requests for logout operations. Additionally, the removal of the console log is a good practice for production code to avoid exposing potentially sensitive information.src/components/Banners/Banner.css (2)
200-205: The font size for
.mib_top_intro > h1has been reduced from an unspecified larger size to25px. This change should be verified to ensure it aligns with the intended design and maintains readability across different devices. If this change was made to improve responsiveness or visual hierarchy, it would be beneficial to mention the rationale in the pull request summary or comments for clarity.273-278: The padding for
.mib_mainparenthas been reduced from20.5pxto10.5pxon screens with a maximum width of500px. Additionally, the font size for.mib_top_intro > h1within the same media query has been reduced from25pxto23px. These changes should be checked for consistency with the design specifications and to ensure that they do not negatively impact the user experience on smaller screens.
| font-size: 0.9rem; | ||
| } | ||
|
|
||
| #reportForm { | ||
| font-family: "Poppins"sans-serif; |
There was a problem hiding this comment.
@dhananjay-Byte There is a missing comma between the font family name and the fallback font sans-serif. This could lead to unexpected behavior in how the font is rendered if the primary font is not available.
- font-family: "Poppins"sans-serif;
+ font-family: "Poppins", sans-serif;Commitable suggestion
[!IMPORTANT]
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| font-family: "Poppins"sans-serif; | |
| font-family: "Poppins", sans-serif; |
tamalCodes
added
status: wip 👩🏻💻
closes #1134
👷🏻 Changes made
changed the hover effect of the outline buttons.
📸 Screenshots
Summary by CodeRabbit
Documentation
Bug Fixes
userEndpointsobject for user reports.Style
.mib_numbercircleand adjusted font size in.mib_top_intro > h1.Chores
MilaninfobannerandFootercomponents.Modalcomponent by removing unnecessary code related tocreatePortal.Refactor
Logoutfunction to use a POST request instead of a GET request.