Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: footer is added to shop and user profile pages #1163

Closed
wants to merge 1 commit into from

Conversation

YashM211
Copy link

closes #1160

👷🏻 Changes made

Footer component is added to shop and user profile page. Now these pages are showing the footer section.

@github-actions github-actions bot added hacktoberfest-accepted This PR is accepted for Hacktoberfest. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 🐞 bug This is a patch, generally fixing some bugs. labels Oct 30, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @YashM211, thank you for raising a pull request.

Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at [email protected] if you think that this pull request is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@github-actions github-actions bot temporarily deployed to Preview October 30, 2023 21:23 Inactive
@github-actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: b6a9a9b
✅ Preview: https://milan-hp3c6fezk-iamtamal.vercel.app
🔍 Inspect: https://vercel.com/iamtamal/milan/27NhsCptsZoHRdRWk12KFkuDgkqz

View Workflow Logs

@tamalCodes
Copy link
Member

Please donot create PR(s) without getting assigned. That may lead to a lot of different complications.

@tamalCodes tamalCodes closed this Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug This is a patch, generally fixing some bugs. hacktoberfest-accepted This PR is accepted for Hacktoberfest. status: todo ⏳ This issue is yet to be seen by the maintainer of the project.
Projects
Status: Merged/Discarded
Development

Successfully merging this pull request may close these issues.

Bug: the shop portal and user profile are missing the footer
2 participants