-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: changed button hover effect #1139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @dhananjay-Byte, thank you for raising a pull request.
Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.
Feel free to reach out to Tamal on Twitter, or drop a mail at [email protected] if you think that this pull request is of critical priority.
Give us a ⭐ to show some support
Happy OpenSource 🚀
Hi @dhananjay-Byte , the changes look good however I would recommend a small change. Please make these changes, and ask for a review. I'll merge it soon. |
got it |
Let's catch up 🙋🏻♂️Hi there, it has been a while since we last had a conversation so I wanted to know if you are still working on this. Please drop a reply shortly so that we know you are active, feel free to convey any problem you face in the comments, or mail me at [email protected] |
sorry for being inactive @tamalCodes ill patch up this work ASAP from now. |
WalkthroughThe changes in this pull request primarily focus on enhancing the user interface of the Milan Community website. The CSS styles for the ".solid" class in the GlobalButton component have been modified to provide a more distinctive hover effect for buttons, addressing user feedback. Changes
Assessment against linked issues (Beta)
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- src/components/Button/GlobalButton/Button.module.css (1 hunks)
Files skipped from review due to trivial changes (1)
- src/components/Button/GlobalButton/Button.module.css
This pull request has been deployed to Vercel.
|
closes #1134
👷🏻 Changes made
Add a background color to show the differentiation between the buttons which is hovered by the user.
📸 Screenshots
Before:
After:
Summary by CodeRabbit