Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rcsb provider fixes #1043

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Rcsb provider fixes #1043

merged 2 commits into from
Jun 23, 2024

Conversation

ppillot
Copy link
Collaborator

@ppillot ppillot commented Jun 23, 2024

This PR fixes 2 issues:

  • mmtf format is not supported by data providers (RCSB and PDBe)
  • RCSB redirects from http to https but this can't be followed by the request code. Calls are now only made to https

default to binary cif when no extension provided
RCSB redirects calls from http to https, but the redirection is not handled by the Streamer code.
MMTF support has now been removed from RCSB. Default to bfic for compatibility and log warnings.
@ppillot ppillot requested a review from fredludlow June 23, 2024 16:03
@ppillot ppillot merged commit 598e005 into nglviewer:master Jun 23, 2024
2 checks passed
@ppillot ppillot mentioned this pull request Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant