Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customizable exception page with @app.error(500) #32

Merged
merged 7 commits into from
Nov 15, 2023
Merged

customizable exception page with @app.error(500) #32

merged 7 commits into from
Nov 15, 2023

Conversation

nggit
Copy link
Owner

@nggit nggit commented Nov 13, 2023

Example:

@app.error(500)
async def exception_handler(**server):
    exc = server['exc']

    return str(exc)

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (8a4cd41) 91.27% compared to head (170215e) 92.39%.
Report is 9 commits behind head on master.

❗ Current head 170215e differs from pull request most recent head 833e8a8. Consider uploading reports for the commit 833e8a8 to get more accurate results

Files Patch % Lines
tremolo/tremolo.py 83.06% 21 Missing ⚠️
tremolo/lib/http_protocol.py 90.14% 7 Missing ⚠️
tremolo/lib/http_response.py 92.85% 3 Missing ⚠️
tremolo/asgi_lifespan.py 88.23% 2 Missing ⚠️
tremolo/lib/tasks.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   91.27%   92.39%   +1.11%     
==========================================
  Files          19       19              
  Lines        1720     1854     +134     
==========================================
+ Hits         1570     1713     +143     
+ Misses        150      141       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nggit nggit merged commit 2f16c98 into master Nov 15, 2023
@nggit nggit deleted the updates branch November 15, 2023 22:10
nggit added a commit that referenced this pull request Aug 8, 2024
* customizable exception page with @app.error(500)

* implement app_handler_timeout

* more efficient ASGILifespan impl.

---------

Co-authored-by: nggit <[email protected]>
nggit added a commit that referenced this pull request Aug 8, 2024
* customizable exception page with @app.error(500)

* implement app_handler_timeout

* more efficient ASGILifespan impl.

---------

Co-authored-by: nggit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant