Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable check for metadata sheetname and is meta data sheet for arc template #456

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

Etschbeijer
Copy link
Collaborator

Closes Issue #453

Copy link
Collaborator

@Freymaurer Freymaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update references below to use the new isMetadataSheet logic.

Similiar to here:

let tryGetMetadataSheet (doc : FsWorkbook) =

@HLWeil
Copy link
Member

HLWeil commented Oct 18, 2024

Hey, the Commit (and by this also PR message) could be a bit more concise. Especially Template is missing. But otherwise looks fine.

Also you should extend the logic to match that of ArcAssay and ArcStudy. Making use of the function you created. This way it would also transitively be tested.

EDIT: Just as @Freymaurer also mentioned

@Etschbeijer Etschbeijer changed the title Enable check for metadata sheetname and is meta data sheet Enable check for metadata sheetname and is meta data sheet for arc template Oct 18, 2024
@Etschbeijer
Copy link
Collaborator Author

Hey, the Commit (and by this also PR message) could be a bit more concise. Especially Template is missing. But otherwise looks fine.

Also you should extend the logic to match that of ArcAssay and ArcStudy. Making use of the function you created. This way it would also transitively be tested.

EDIT: Just as @Freymaurer also mentioned

Should be fixed now

Copy link
Member

@HLWeil HLWeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, usage of the newly added function in the "fromFsWorkbook" function is still missing. Line 277 including your changes

@Etschbeijer
Copy link
Collaborator Author

Etschbeijer commented Oct 18, 2024

Hey, usage of the newly added function in the "fromFsWorkbook" function is still missing. Line 277 including your changes

@HLWeil Do you mean in the tests?

@HLWeil
Copy link
Member

HLWeil commented Oct 21, 2024

No, I mean here:

image

@HLWeil HLWeil merged commit 35ee4ae into main Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants