Feature enable sequence based metadata creation #451
Conversation
There was a problem hiding this comment.
Thanks for the PR!
Please reuse the fromRows function to reduce code duplication.
And please undo the styling changes not connected to the specific functions you change, to keep the PR more clean.
Also I would prefer to keep the param : type styling in general. With the ,, I'm not sure yet. But I heavily advocate against including this kind of cleanups of code-parts unrelated to the PR.
src/Spreadsheet/ArcAssay.fs
Outdated
|
|
||
| let fromMetadataCollection (collection: seq<seq<string option>>) : ArcAssay = | ||
| try | ||
| let fromRows (usePrefixes: bool) (rows: seq<SparseRow>) = |
There was a problem hiding this comment.
Pull this (fromRows) function out to be used both in fromMetadataSheet and your function.
src/Spreadsheet/ArcAssay.fs
Outdated
| let rows = | ||
| collection | ||
| |> Seq.map SparseRow.fromAllValues | ||
| let hasPrefix = |
There was a problem hiding this comment.
This hasPrefix part can be moved into the fromRows function and dropped as a param there.
Fixed the parameter styling and I will avoid style changes in the futur. |
Closses #447