-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function for updating IO types against each other in ARC #227
Conversation
src/ISA/ISA/ArcTypes/ArcTable.fs
Outdated
@@ -285,6 +285,40 @@ type ArcTable(name: string, headers: ResizeArray<CompositeHeader>, values: Syste | |||
fun (table:ArcTable) -> | |||
table.TryGetColumnByHeader(header) | |||
|
|||
member this.GetInputColumn() = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use TryGetInputColumn
here and add match case with descriptive error message
src/ISA/ISA/ArcTypes/ArcTable.fs
Outdated
fun (table:ArcTable) -> | ||
table.TryGetInputColumn() | ||
|
||
member this.GetOutputColumn() = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use TryGetOutputColumn
here and add match case with descriptive error message
src/ISA/ISA/ArcTypes/ArcTypes.fs
Outdated
/// E.g. RawDataFile is more specific than Source, but less specific than DerivedDataFile. | ||
/// | ||
/// E.g. Sample is equally specific to RawDataFile. | ||
member this.UpdateIO() = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expected you to do this update only on deprecated header formats (Without "Input"/"Output"). Should this function not only exist on the read-in functions?
I cannot find it, where do we handle deprecated headers again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And should the whole logic not be based on:
Output with same id as Input overwrites input IOType
Because this would resolve deprecation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed and added some documentation. I would keep it here, as it can also be used to check up on erroneous, non-deprecated arcs. And also the functionality needs to be spanning across files, making it infeasible to keep only in ISA IO.
closes #150