Add function for updating IO types against each other in ARC #227
Conversation
src/ISA/ISA/ArcTypes/ArcTable.fs
Outdated
| @@ -285,6 +285,40 @@ type ArcTable(name: string, headers: ResizeArray<CompositeHeader>, values: Syste | |||
| fun (table:ArcTable) -> | |||
| table.TryGetColumnByHeader(header) | |||
|
|
|||
| member this.GetInputColumn() = | |||
There was a problem hiding this comment.
use TryGetInputColumn here and add match case with descriptive error message
src/ISA/ISA/ArcTypes/ArcTable.fs
Outdated
| fun (table:ArcTable) -> | ||
| table.TryGetInputColumn() | ||
|
|
||
| member this.GetOutputColumn() = |
There was a problem hiding this comment.
use TryGetOutputColumn here and add match case with descriptive error message
src/ISA/ISA/ArcTypes/ArcTypes.fs
Outdated
| /// E.g. RawDataFile is more specific than Source, but less specific than DerivedDataFile. | ||
| /// | ||
| /// E.g. Sample is equally specific to RawDataFile. | ||
| member this.UpdateIO() = |
There was a problem hiding this comment.
I expected you to do this update only on deprecated header formats (Without "Input"/"Output"). Should this function not only exist on the read-in functions?
I cannot find it, where do we handle deprecated headers again?
There was a problem hiding this comment.
And should the whole logic not be based on:
Output with same id as Input overwrites input IOType
Because this would resolve deprecation?
There was a problem hiding this comment.
Renamed and added some documentation. I would keep it here, as it can also be used to check up on erroneous, non-deprecated arcs. And also the functionality needs to be spanning across files, making it infeasible to keep only in ISA IO.
closes #150