Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developer copy #159

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Developer copy #159

merged 3 commits into from
Aug 4, 2023

Conversation

Freymaurer
Copy link
Collaborator

Closes #158
Closes #156

@Freymaurer Freymaurer changed the base branch from main to developer August 4, 2023 13:36
@Freymaurer
Copy link
Collaborator Author

Ups nearly requested merge on main :octocat:

@HLWeil
Copy link
Member

HLWeil commented Aug 4, 2023

Should we remove transpiled js files from git tracking?

HLWeil
HLWeil reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@HLWeil HLWeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy and paket changes look good!
keeping all transpiled files seems a bit excessive. I mean this might even get worse with python and friends

@HLWeil
Copy link
Member

HLWeil commented Aug 4, 2023

Ups nearly requested merge on main :octocat:

You can switch the PR target after the fact 🆒

@Freymaurer
Copy link
Collaborator Author

Should we remove transpiled js files from git tracking?

Yes might be a good idea, will push the change

@Freymaurer Freymaurer merged commit a20d86d into developer Aug 4, 2023
2 checks passed
@HLWeil HLWeil mentioned this pull request Aug 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HLWeil HLWeil HLWeil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Freymaurer @HLWeil