Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

biocatalysis demo vocabulary re-submission 20240222 #9

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

markdoerr
Copy link
Contributor

No description provided.

@markdoerr
Copy link
Contributor Author

Hi @dalito ,
I could not find this "allow edits by the maintainer" button in the whole PR process - where should that be ?

@dalito
Copy link
Member

dalito commented Feb 22, 2024

See #10 for the screenshot. What I did for #10:

  • cloned this repo to my account,
  • created a branch biocatal-test,
  • added & committed the xlsx-file to this branch,
  • pushed the changes to GitHub

This led to a yellow dialog popping up on the main view of my clone in GitHub asking if I want to create a fork, which I did. This directed me to the view where the screenshot in #10 is from.

@dalito
Copy link
Member

dalito commented Feb 22, 2024

One possibility why the allow-edits-by-maintainer does not show up is that you created the PR from the main branch of your fork. Main seems to be protected against external updates although no special protection rule for main is transferred to a fork (I checked that for my fork).

I also found in GitHub documentation that "Allow edits by maintainers" should always be visible on the right side bar in the PR view. It should be possible to change the status at any time after PR creation (in #10 it is as described). So committing changes to "main" and making a PR from main was probably causing the difficulties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants